JavaScript: Simplify flow-summary queries.#1131
Merged
semmle-qlci merged 1 commit intoMar 19, 2019
Merged
Conversation
Previously, `AllConfigurations.qll` would pull in (almost) all taint tracking configurations, which has started causing OOMEs during compilation. I've pruned it down to only the most interesting configurations. Since flow summaries are experimental at this point and require a bit of manual configuration anyway, this shouldn't be much of an issue in practice.
asger-semmle
approved these changes
Mar 19, 2019
asger-semmle
left a comment
asger-semmle
left a comment
Contributor
There was a problem hiding this comment.
LGTM
I can imagine RequestForgery and TypeConfusionThroughParameterTampering might be worth bringing back later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
AllConfigurations.qllwould pull in (almost) all tainttracking configurations, which has started causing OOMEs during
compilation.
I've pruned it down to only the most interesting configurations. Since
flow summaries are experimental at this point and require a bit of manual
configuration anyway, this shouldn't be much of an issue in practice.
(No documentation impact.)